Refactor Players 5/12: generic player selection layout#1288
Draft
dgruss wants to merge 5 commits into
Draft
Conversation
dgruss
changed the title
dgruss
force-pushed
the
refactorplayers-12-05-player-selection-layout
branch
from
May 12, 2026 09:40
9c4fb9a to
46ac11c
Compare
dgruss
marked this pull request as draft
May 26, 2026 05:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of splitting #1186. Builds on #1287.
Files changed in this PR:
This migrates the name/party player setup screens to the generic player layout helper. From here, this is no longer only preparation: the screen is actively using the new placement system.
Comparison for 2 players (right one is new):
Comparison for 6 players: